Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub operations should handle rate limitting #52

Open
rwinch opened this issue Apr 1, 2016 · 5 comments
Open

GitHub operations should handle rate limitting #52

rwinch opened this issue Apr 1, 2016 · 5 comments

Comments

@rwinch
Copy link
Collaborator

rwinch commented Apr 1, 2016

No description provided.

@rwinch rwinch changed the title Need all git operations to handle rate limitting GitHub operations should handle rate limitting Apr 1, 2016
@mp911de
Copy link
Collaborator

mp911de commented Apr 7, 2016

I see two options: 1. show an error page with "come back later" (if facing the user) or use event sourcing so actions are not lost. That would play nicely also with headless operations if the Github hook is triggered but github-cla is not able to update the PR status because of rate limiting errors.

@Shredder121
Copy link
Contributor

I think there is one more option.
3) Ask GitHub for a bigger quota on a key.

Or is that not a viable option? How much does the app exceed the regular quota?

@rwinch
Copy link
Collaborator Author

rwinch commented Jun 15, 2016

@Shredder121 Thanks for the response. We haven't yet run over the quota, but we have only rolled out to a few applications. We can ask for more quota, but of course we can always end up exceeding the new quota too.

@Shredder121
Copy link
Contributor

Yes, I see.
I was just wondering if you already knew how much quota was needed.

There are some conditional requests that we could employ, but other than that it's mostly POSTs, so the best we can do is hold off requests until something changes (no unnecessary commit statuses, comments and the like).

Just wondering, how much has gone into conditional requests so far?

@rwinch
Copy link
Collaborator Author

rwinch commented Jun 15, 2016

Thanks for the reply. We could do conditional requests, but at that point we would still need to give an error to the user saying we cannot display it. To me the effort for this would probably not be worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants