Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search not implemented #6

Open
vfedoriv opened this issue Feb 20, 2017 · 10 comments
Open

Search not implemented #6

vfedoriv opened this issue Feb 20, 2017 · 10 comments

Comments

@vfedoriv
Copy link
Collaborator

Need add search options (owner by name etc...)

@simrin051
Copy link
Contributor

@vfedoriv @arey

Can i take up this issue

@simrin051
Copy link
Contributor

Hi @vfedoriv / @arey

I can take up this issue and form validation issue

@simrin051
Copy link
Contributor

Hi @vfedoriv / @arey

I am not clear with this issue. May i know whether search by owner name option is needed in the drop down box of owners.

image

@arey
Copy link
Member

arey commented Sep 18, 2021

I propose to rename the All entry menu to Search then add a filter input text in this screen.
I don't remember if the REST API expose a search endpoint?

@simrin051
Copy link
Contributor

simrin051 commented Sep 18, 2021

Hi @arey
There is an API exposed with last name. We can use this API..
@RequestMapping(value = "/*/lastname/{lastName}", method = RequestMethod.GET, produces = "application/json")
public ResponseEntity<Collection> getOwnersList(@PathVariable("lastName") String ownerLastName) {.....}

May i know what should be returned,should it return only owner name or owner details also

@arey
Copy link
Member

arey commented Sep 18, 2021

You may test the seach feature of the original version of Petclinic here: https://spring-petclinic-community.herokuapp.com/owners?lastName=E

@simrin051
Copy link
Contributor

image
image
May i know is this fine @arey

@arey
Copy link
Member

arey commented Sep 21, 2021

Yes it looks like great

@simrin051
Copy link
Contributor

May i know whether i should implement for Vets also?
getAllVets() is the only method exposed API end point ( http://localhost:9966/vets.html )
Can you please advice @arey

@simrin051
Copy link
Contributor

Sorry @arey you have commented this on the wrong window. I have the below doubt.

May i know whether i should implement for Vets also?
getAllVets() is the only method exposed API end point ( http://localhost:9966/vets.html )
Can you please advice @arey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants