-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce infrastructure requirements of Examples #420
Labels
Comments
schauder
added a commit
that referenced
this issue
Oct 25, 2018
If the Solr examples don't find a Solr instance already running a Docker container is started with the correct variant of Solr running. Cleaned up the test setup which was suffering from side effects between the tests and also dependent on the Solr version in use.
schauder
added a commit
that referenced
this issue
Oct 26, 2018
schauder
added a commit
that referenced
this issue
Oct 29, 2018
Tests using the new Rule can try multiple strategies to find a suitable database. Typically first looking for a local one and alternatively creating one using Docker via Testcontainers. If no database is found the tests get skipped by default. If the tests are run with `-DignoreMissingInfrastructure=false` the first test with each Rule instance will fail, making the build fail. Added the InfrastructureRule to ignore/fail tests depending on the presence of a required infrastructure. Implemented that Rule for R2DBC and Solr.
schauder
added a commit
that referenced
this issue
Oct 29, 2018
Tests using the new Rule can try multiple strategies to find a suitable database. Typically first looking for a local one and alternatively creating one using Docker via Testcontainers. If no database is found the tests get skipped by default. If the tests are run with `-DignoreMissingInfrastructure=false` the first test with each Rule instance will fail, making the build fail. Added the InfrastructureRule to ignore/fail tests depending on the presence of a required infrastructure. Implemented that Rule for R2DBC and Solr.
schauder
added a commit
that referenced
this issue
Oct 29, 2018
schauder
added a commit
that referenced
this issue
Oct 29, 2018
Tests using the new Rule can try multiple strategies to find a suitable database. Typically first looking for a local one and alternatively creating one using Docker via Testcontainers. If no database is found the tests get skipped by default. If the tests are run with `-DignoreMissingInfrastructure=false` the first test with each Rule instance will fail, making the build fail. Added the InfrastructureRule to ignore/fail tests depending on the presence of a required infrastructure. Implemented that Rule for R2DBC and Solr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Building examples should succeed even without any database running, nor Docker available.
It should be possible to either have a database running locally or docker available to execute the tests.
There should be a maven profile that forces the execution of tests, so no tests get silently ignored due to lack of infrastructure.
And everything in a way that looks the same for all modules.
The text was updated successfully, but these errors were encountered: