Extract repeated string literals in SimpleJpaRepository to constants
#3698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
mp911de
changed the title
SimpleJpaRepository to constants
mp911de
added
type: task
mp911de
added a commit
that referenced
this pull request
Dec 10, 2024
Extract assertion message constants from QuerydslJpaPredicateExecutor. See #3698
mp911de
pushed a commit
that referenced
this pull request
Dec 10, 2024
mp911de
added a commit
that referenced
this pull request
Dec 10, 2024
Extract assertion message constants from QuerydslJpaPredicateExecutor. See #3698
mp911de
pushed a commit
that referenced
this pull request
Dec 10, 2024
mp911de
added a commit
that referenced
this pull request
Dec 10, 2024
Extract assertion message constants from QuerydslJpaPredicateExecutor. See #3698
|
Thank you for your contribution. That's merged, polished, and backported now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit replaces repeated string literals with constants, which is expected to improve the maintainability of the code.
In addition to this commit, I was considering committing a change to overload the getQueryString method and apply lazy evaluation. However, I'm unsure if this change would actually provide any significant benefits. I would like to know your thoughts on this approach.