Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geo / Spatial #2410

Closed
xenoterracide opened this issue Oct 24, 2021 · 5 comments
Closed

Geo / Spatial #2410

xenoterracide opened this issue Oct 24, 2021 · 5 comments
Assignees
Labels
type: documentation A documentation update

Comments

@xenoterracide
Copy link

Does Spring Data Neo4j support Data Commons Geo/Neo4j Spatial? if so, could some reference documentation, and maybe a guide for working with map data be added? if not are patches welcome?

I can't give any time frame to when I might be able to work on it, and could probably use some mentorship if that's necessary.

P.S. I kind of hate the mass import of the Spring Data Commons Reference Documentation into the Spring Data Neo4j documentation. It makes it impossible to tell what is actually supported. IMHO it would be better to simply link to specific sections that are supported for sure.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 24, 2021
@michael-simons
Copy link
Collaborator

Hi @xenoterracide Yes, Neo4j spatial types are well supported. Mappable into our own data types as well as into org.springframework.data.geo.Point

Also, derived WITHIN queries are supported.

PS: Yes, we do to, but this is how the projects are setup. This is an issue to be raised with VMWare, maybe at https://github.com/spring-projects/spring-data-commons

If this answers your question, please close the issue again.

@michael-simons michael-simons added for: stackoverflow A question that's better suited to stackoverflow.com and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 25, 2021
@xenoterracide
Copy link
Author

xenoterracide commented Oct 25, 2021

Hmm... there's still not any examples of usage in the docs, or how to set up (the neo4j server part of this could just be a link back to their documentation imo). It could / should be mentioned in the neo4j documentation parts I think. That would have prevented the question of "is it supported" in the first place. This is especially true because the common documentation mentions that it depends on your implementation of whether it's supported. Also spring-projects/spring-data-commons#2489

Also, imho, if people ask questions it's always a good idea to document unless it would be completely inappropriate for some reason. I don't think it's inappropriate in this case; see above paragraph. I very much try to ask questions that shouldn't be in the documentation on stack overflow.

VMware? I thought they had spit pivotal out. Did they reacquire?

@michael-simons
Copy link
Collaborator

https://docs.spring.io/spring-data/neo4j/docs/6.1.5/reference/html/#why-should-you-favor-sdn

Support for all modifiers and variations of derived finder methods, including spatial queries

But yes, you are correct.
However, there's little to setup: You just use the types mentioned above, but yeah, should be part of the docs.

Pivotal is thing of the past… https://www.vmware.com/company/acquisitions/pivotal.html

@michael-simons michael-simons added type: documentation A documentation update and removed for: stackoverflow A question that's better suited to stackoverflow.com labels Oct 25, 2021
@xenoterracide
Copy link
Author

I was searching for "geo" after finding a reference to it in the comments portion of the documentation. If that helps in adding.

@xenoterracide
Copy link
Author

Also I opened a request for a guide spring-guides/getting-started-guides#148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

No branches or pull requests

4 participants