fix: amqp channel name when using exchange #886
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for springwolf-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
timonback
commented
Jul 31, 2024
| } | ||
| } | ||
| }, | ||
| "queue-read_#_CRUD-topic-exchange-2": { |
There was a problem hiding this comment.
Does this make sense?
This is an entry of type is=routingKey, which belongs to an exchange.
However the routingKey is not specified.
Instead, the routingKey is part of the channelIdentifier - which has no special meaning.
Does the spec require the field routingKey?
Similarly, is the target queue (binding) needed as well, especially since the routingKey can also be a pattern.
timonback
commented
Jul 31, 2024
...in/java/io/github/springwolf/plugins/amqp/asyncapi/scanners/bindings/RabbitListenerUtil.java
Outdated
Show resolved
Hide resolved
timonback
commented
Jul 31, 2024
...in/java/io/github/springwolf/plugins/amqp/asyncapi/scanners/bindings/RabbitListenerUtil.java
Outdated
Show resolved
Hide resolved
timonback
changed the title
timonback
force-pushed
the
reproduce/amqp-channel-name
branch
from
1f369d9
to
36f34bc
Compare
timonback
force-pushed
the
reproduce/amqp-channel-name
branch
from
36f34bc
to
5b60dc8
Compare
test(amqp): update e2e test(amqp): wait for ready amqp server chore(amqp): add spring-messaging dependency in example test(amqp): persist patched asyncapi.yaml chore(amqp): use non-exclusive queue in example test: add WaitStrategy for ApiSystemTest feat(ui): show channel bindings test(amqp): update asyncapi artifacts chore(ui): fix formatting test(ui): use valid mock data test(amqp): update asyncapi artifacts Part of springwolfGH-366 feat(amqp): scan all queues In addition to the routingKeys chore: update asyncapi.yaml gradle script chore(amqp): simplify local testing chore(amqp): fix queue configuration tests: additional RabbitListener tests tests: refactoring + add yaml endpoint testing
In case spring-amqp changes how it handles inputs, the library should still try to do its best
…produce/amqp-channel-name * refs/remotes/springwolf/master: (34 commits) chore(example): Bump rabbitmq from 3.9-management-alpine to rabbitmq:4.0-management-alpine in amqp-example chore(example): Bump confluentinc/cp-kafka from 7.4.6 to 7.7.1 in cloud-stream-example chore(example): Bump apache/activemq-artemis from 2.34.0/2.31.2 to 2.37.0-alpine in jms-example chore(example): Bump confluentinc/cp-kafka from 7.4.6 to 7.7.1 in kafka-example chore(example): Bump localstack/localstack from 2.2.0 to 3.7.2 in sns-example chore(example): Bump localstack/localstack from 3.3.0 to 3.7.2 in sqs-example chore: start development on springwolf 1.8.0-SNAPSHOT chore(deps): Bump org.springframework.boot from 3.3.3 to 3.3.4 (springwolf#986) test(jms): increase timeout of ProducerSystemTest from 10s to 20s to fix flaky test (springwolf#992) chore(deps): Bump io.awspring.cloud:spring-cloud-aws-dependencies (springwolf#987) chore(deps): Bump protobufJavaVersion from 4.28.1 to 4.28.2 (springwolf#989) chore(deps): Bump swaggerVersion from 2.2.23 to 2.2.24 (springwolf#988) chore(deps): Bump com.networknt:json-schema-validator (springwolf#990) chore(deps): Bump the dependencies-angular group across 1 directory with 12 updates (springwolf#983) chore(deps): Bump junitJupiterVersion from 5.10.3 to 5.11.0 (springwolf#933) chore(deps): Bump the npm_and_yarn group (springwolf#973) chore(deps-dev): Bump @types/jest in /springwolf-ui (springwolf#976) chore(gh): allow ui pipeline to publish to gh-pages branch Chore/gradle 8.10.1 (springwolf#981) Feat/add options to amqp annotation (springwolf#980) ...
timonback
force-pushed
the
reproduce/amqp-channel-name
branch
from
888a78a
to
33fac8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebased and continued version of #790
relates to #366