Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation error with fresh build depending on didkit 0.3.0 #277

Open
cobward opened this issue Mar 14, 2022 · 3 comments
Open

Compilation error with fresh build depending on didkit 0.3.0 #277

cobward opened this issue Mar 14, 2022 · 3 comments
Labels
regression Bugs that returned, and/or functionality that was inadvertently removed

Comments

@cobward
Copy link

cobward commented Mar 14, 2022

Building a crate that depends on didkit 0.3.0 will fail for fresh builds (no Cargo.lock). This can be replicated by creating a new crate which only depends on didkit 0.3.0 and running cargo build.

This is due to didkit 0.3.0 depending on ssi 0.3.0 and did_methods of the form "x.y". Did method crates increment z when ssi is upgraded, so both ssi v0.4.0 and v0.3.0 are in the dependency tree of didkit.

I suggest:

  • We release didkit v0.3.1 and yank v0.3.0.
  • Going forwards in didkit we always depend on did method versions of the form x.y.z to prevent ssi version clashes.
@clehner clehner mentioned this issue Mar 14, 2022
@clehner
Copy link
Contributor

clehner commented Apr 12, 2022

I think this is fixed; @cobward can you confirm?

@clehner clehner added the regression Bugs that returned, and/or functionality that was inadvertently removed label Apr 12, 2022
@cobward
Copy link
Author

cobward commented Apr 13, 2022

Yes, just checked. This works now by depending on 0.3.1. Do we want to yank 0.3.0?

@nayrban
Copy link

nayrban commented May 24, 2022

I also saw that for ssi version 0.3 the ethr version is 0.0.1 not 0.1.0 so we still have the compile issue, same for the other dependencies that we use from ssi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression Bugs that returned, and/or functionality that was inadvertently removed
Projects
None yet
Development

No branches or pull requests

3 participants