Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[On Hold] Implement CoseMac0 #66

Open
3 of 4 tasks
justAnIdentity opened this issue Oct 31, 2023 · 3 comments
Open
3 of 4 tasks

[On Hold] Implement CoseMac0 #66

justAnIdentity opened this issue Oct 31, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@justAnIdentity
Copy link
Contributor

justAnIdentity commented Oct 31, 2023

  • [cose] Implement structural definitions for CoseMac0.
  • [cose] Implement Mac generation algorithm.
  • [cose] Implement Mac verification algorithm.
  • [isomdoc] Add support for CoseMac0 to mdoc and reader authentication
@radumarias radumarias self-assigned this Jul 15, 2024
@radumarias radumarias added the enhancement New feature or request label Jul 15, 2024
@radumarias
Copy link
Contributor

Initial implementation spruceid/cose-rs#16

@radumarias
Copy link
Contributor

radumarias commented Jul 17, 2024

continue working on:

  • [isomdoc] Add support for CoseMac0 to mdoc and reader authentication

For this I'm thinking to create a trait Cose that have some common methods between Cose_Mac0 and Cose_Sign1 that uses Signer and Verifier from the new common module and have smth like

Document<C: Cose> {
  pub issuer_auth: C,

and maybe default it to Cose_Sign1

  1. similar in PreparedDocument, DeviceAuth, IssuerSigned, Mdoc, PreparedMdoc

  2. Also we could use structs from common module https://github.com/spruceid/cose-rs/blob/feat/Implement_CoseMac0_66/src/common.rs in Cose_Sign1 also

This would give us a generic use of Cose objects and ability to maybe implement encryption also in the future

@sbihel @cobward @wyc please let me know what you think, how would be best to integrate it?

@radumarias radumarias linked a pull request Jul 22, 2024 that will close this issue
8 tasks
@radumarias
Copy link
Contributor

if we integrate coset this will become obsolete #86

@radumarias radumarias changed the title Implement CoseMac0 [On Hold] Implement CoseMac0 Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants