Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Give more descriptive names to the shortcuts that control the Debugger #23562

Merged

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented Jan 26, 2025

Description of Changes

  • This is necessary since now that those shortcuts are global (i.e. not prefixed by "debugger"), it was difficult to understand what a shortcut about "next" or "continue" referred to in Preferences.
  • Also, make shortcut to debug a file global because that's how things worked in Spyder 5 and fix a test related to filtering shortcuts with the word "debug".

Issue(s) Resolved

Follow-up of PR #23452.

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

- This is necessary since now that those shortcuts are global (i.e. not
prefixed by "debugger"), it was difficult to understand what a shortcut
about "next" or "continue" referred to.
- Also, make shortcut to debug a file global because that's how things
worked in Spyder 5 and fix a test related to filtering shortcuts with
the word "debug".
@ccordoba12 ccordoba12 added this to the v6.0.4 milestone Jan 26, 2025
@ccordoba12 ccordoba12 self-assigned this Jan 26, 2025
@ccordoba12 ccordoba12 merged commit 0a187a7 into spyder-ide:master Jan 26, 2025
17 checks passed
@ccordoba12 ccordoba12 deleted the improve-debugger-shortcut-names branch January 26, 2025 21:22
@ccordoba12
Copy link
Member Author

@meeseeksdev please backport to 6.x

Copy link

lumberbot-app bot commented Jan 26, 2025

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 6.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 0a187a7e48e46f6904157ca05e0d5a3880490180
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #23562: PR: Give more descriptive names to the shortcuts that control the Debugger'
  1. Push to a named branch:
git push YOURFORK 6.x:auto-backport-of-pr-23562-on-6.x
  1. Create a PR against branch 6.x, I would have named this PR:

"Backport PR #23562 on branch 6.x (PR: Give more descriptive names to the shortcuts that control the Debugger)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

ccordoba12 added a commit to ccordoba12/spyder that referenced this pull request Jan 26, 2025
ccordoba12 added a commit that referenced this pull request Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant