Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple the argument settings for common/ps. #2103

Open
brightcoder01 opened this issue Jul 1, 2020 · 0 comments
Open

Decouple the argument settings for common/ps. #2103

brightcoder01 opened this issue Jul 1, 2020 · 0 comments
Assignees

Comments

@brightcoder01
Copy link
Collaborator

brightcoder01 commented Jul 1, 2020

Currently the argument parser setting for PS is tightly coupled with common parameters. But there are a lot of parameters which are not required by the parameter server. We need decouple these two parts.

def parse_ps_args(ps_args=None):
parser = argparse.ArgumentParser(description="ElasticDL PS")
parser.add_argument(
"--ps_id", help="ID unique to the PS", type=int, required=True
)
parser.add_argument(
"--port", help="Port used by the PS pod", type=int, required=True
)
parser.add_argument("--master_addr", help="Master ip:port")
add_common_params(parser)
add_train_params(parser)

@brightcoder01 brightcoder01 self-assigned this Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant