Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Support other database such as clickhouse #2158

Open
wingerted opened this issue Jul 13, 2020 · 1 comment
Open

Feature Request: Support other database such as clickhouse #2158

wingerted opened this issue Jul 13, 2020 · 1 comment

Comments

@wingerted
Copy link

How to support clickhouse or mysql?

@skydoorkai
Copy link
Collaborator

skydoorkai commented Jul 15, 2020

In the current ElasticDL version, one way to support clickhouse or MySQL is using custom_data_reader_params.
Shard is defined as (shard_name, start_index, num_record).
Task is defined as (shard_name, start_index, end_index)
Thus, need to put all required info to access clickhouse or MySQL in shard_name, which is a string.
Also need to implement data reading in read_records using (shard_name, start_index, end_index).

https://github.com/sql-machine-learning/elasticdl/blob/develop/docs/designs/custom_data_source_support.md

We are working on supporting more general data sources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants