feat: make summarizer the default profile #78
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zakiali
reviewed
Sep 19, 2024
| @@ -49,6 +49,6 @@ def default_profile(provider: str, processor: str, accelerator: str, **kwargs: D | |||
| provider=provider, | |||
| processor=processor, | |||
| accelerator=accelerator, | |||
| moderator="truncate", | |||
| moderator="summarize", | |||
There was a problem hiding this comment.
We need to get the token offset / fraction of token count into the Moderator to enable this by default. Currently, it'll summarize the entire context and replace, which I don't think we want.
michaelneale
requested changes
Sep 25, 2024
There was a problem hiding this comment.
I don't think we should do this until summarizer is updated to not hard code gpt4o square/exchange#57
|
closing this as it is more likely to be synopsis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.