Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neovim 0.10.0 Update Breaks Highlight Groups #119

Open
GophUndMe opened this issue May 19, 2024 · 2 comments
Open

Neovim 0.10.0 Update Breaks Highlight Groups #119

GophUndMe opened this issue May 19, 2024 · 2 comments

Comments

@GophUndMe
Copy link

With the new update to Neovim, 0.10.0, some changes to highlighting groups have caused colors to switch roles, some to turn completely white, etc.

I've personally seen this while using Golang highlighting, both with and without Treesitter.

The related patch notes can be found here:

https://neovim.io/doc/user/news-0.10.html

These Nvim specific highlight groups are now defined in a meaningfully different way and might need an update:
[hl-FloatBorder](https://neovim.io/doc/user/syntax.html#hl-FloatBorder) is linked to [hl-NormalFloat](https://neovim.io/doc/user/syntax.html#hl-NormalFloat) instead of [hl-WinSeparator](https://neovim.io/doc/user/syntax.html#hl-WinSeparator).
[hl-NormalFloat](https://neovim.io/doc/user/syntax.html#hl-NormalFloat) is not linked to [hl-Pmenu](https://neovim.io/doc/user/syntax.html#hl-Pmenu).
[hl-WinBar](https://neovim.io/doc/user/syntax.html#hl-WinBar) has different background.
[hl-WinBarNC](https://neovim.io/doc/user/syntax.html#hl-WinBarNC) is similar to [hl-WinBar](https://neovim.io/doc/user/syntax.html#hl-WinBar) but not bold.
[hl-WinSeparator](https://neovim.io/doc/user/syntax.html#hl-WinSeparator) is linked to [hl-Normal](https://neovim.io/doc/user/syntax.html#hl-Normal) instead of [hl-VertSplit](https://neovim.io/doc/user/deprecated.html#hl-VertSplit).
This also might result into some color schemes looking differently due to them relying on implicit assumptions about how highlight groups are defined by default. To account for this, define all attributes of highlight groups explicitly. Alternatively, use :colorscheme vim or :source $VIMRUNTIME/colors/vim.lua to restore previous definitions.

There's a work-around listed, but it doesn't seem to have any effect for me. A fixing update would be appreciated!

@roosta
Copy link
Member

roosta commented May 22, 2024

Hi, thanks for reporting. Could you be a bit more specific about the issues you're experiencing? There's an issue with golang? any other languages you've had issues with? The changenotes for neovim doesn't indicate it should mess with highlight groups.

roosta added a commit that referenced this issue May 24, 2024
Neovim version `0.10` unlinked `NormalFloat` with `pmenu`, which caused
the popup background color to default to undefined (black/magenta etc
depending on what the default colorscheme is)

Should fix the issue reported by @milogert on discord, and return the
previous colors

Ref: #119
roosta added a commit that referenced this issue May 27, 2024
Neovim version `0.10` unlinked `NormalFloat` with `pmenu`, which caused
the popup background color to default to undefined (black/magenta etc
depending on what the default colorscheme is)

Should fix the issue reported by @milogert on discord, and return the
previous colors

Ref: #119
@roosta
Copy link
Member

roosta commented May 29, 2024

Anyone who can shed some more light on this? I don't have the issues reported, but there are other colorschemes having the same issue

They mention a workaround for legacy schemes, but I need to be able to reproduce somehow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants