Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid implementing Crypto-Algorithms by yourself #519

Open
oli-h opened this issue Oct 26, 2023 · 1 comment
Open

Avoid implementing Crypto-Algorithms by yourself #519

oli-h opened this issue Oct 26, 2023 · 1 comment

Comments

@oli-h
Copy link

oli-h commented Oct 26, 2023

In package net.lingala.zip4j.crypto you implemented well known crypto-algprithms:

  • PBKDF2
  • AES

Both are offered out-of-the-box in JDK's javax.crypto library.
Propose to use those as they are well tested and established - and potentially faster.

@jpstotz
Copy link

jpstotz commented Nov 2, 2023

There is already a PR that implements those changes: #449 unfortunately without any comment or response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants