Skip to content
This repository has been archived by the owner on Jan 25, 2024. It is now read-only.

Ensure tests for setters/actions check desired result is achieved #216

Open
kierdavis opened this issue Apr 3, 2019 · 1 comment
Open
Labels
bug Something isn't working

Comments

@kierdavis
Copy link
Contributor

Many of our tests run some code but don't use any assertions to check the code behaved as expected. Essentially these tests are only checking that no exceptions are raised.

This is common among, but not limited to, tests for performing actions on an object or changing its state - we should be checking that the action had the desired effect.

Examples:

@kierdavis kierdavis added the bug Something isn't working label Apr 3, 2019
@kierdavis kierdavis mentioned this issue Apr 3, 2019
@trickeydan
Copy link
Contributor

trickeydan commented Apr 12, 2019

Relevant: #214

@trickeydan trickeydan added this to the v0.6.0 milestone Apr 15, 2019
@trickeydan trickeydan removed this from the v0.6.0 milestone Jun 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants