Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links from development JoE place records to bibliography are resolving to bibl records on production not development #229

Open
wlpotter opened this issue Sep 27, 2024 · 9 comments

Comments

@wlpotter
Copy link
Contributor

For example: https://dev.syriaca.org/johnofephesus/places/5577 in the bibliography section, there are links to the Syriaca/CBSS bibl record, using the Syriaca logo as the clickable link. These links are resolving to a production URL not the dev URL, e.g. http://syriaca.org/cbss/BJFJXJJE rather than http://dev.syriaca.org/cbss/BJFJXJJE.

Since not all of the cbss records are on production these would ideally link to the dev site if possible.

@wlpotter
Copy link
Contributor Author

This may be related to the fact that we have both /bibl/ and /cbss/ URIs. Perhaps we need just the ones with /cbss/ to resolve to development links?

@wsalesky
Copy link
Contributor

It would be easier if they were all /cbss/

@wlpotter
Copy link
Contributor Author

Okay, I think what happened is in the dataset I gave you I had to pull some from the CBSS dataset and some from the old Syriaca bibls, and forgot to update the URIs of the latter. I will do that in the data so they are all cbss URIs and let you know when I've committed those changes to development

@wsalesky
Copy link
Contributor

Great. I will rebuild once they are ready

@wlpotter
Copy link
Contributor Author

Okay, this commit should have normalized all bibl URIs to use /cbss/

@wsalesky
Copy link
Contributor

Okay, running dev build now. It will take 30ish minutes

@wlpotter
Copy link
Contributor Author

Oh wait, I think I missed the URIs in the publicationStmt -- should I update those too? Sorry...

@wsalesky
Copy link
Contributor

@wlpotter Yes, please.

@wlpotter
Copy link
Contributor Author

Okay, done with this commit: srophe/syriaca-data@9a6c628

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants