Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Order can be marked as paid without a PaymentMethod set #378

Open
odrotbohm opened this issue Dec 4, 2021 · 0 comments
Open

Order can be marked as paid without a PaymentMethod set #378

odrotbohm opened this issue Dec 4, 2021 · 0 comments
Labels
module: orders Orders type: enhancement Improvements and new features

Comments

@odrotbohm
Copy link
Member

While the constructor of Order taking a PaymentMethod rejects the parameter being null, nothing in Order makes sure that the method is non-null when ….markPaid() is invoked.
@odrotbohm odrotbohm added module: orders Orders type: enhancement Improvements and new features labels Dec 4, 2021
odrotbohm added a commit that referenced this issue Dec 6, 2021
@odrotbohm
#378 - AuthenticationManagement now allows to update the authentication.
b97514c 
Introduced AuthenticationManagement.updateAuthentication(…) so that changes to the role arrangement of a user can be made effective immediately. The implementation updates SpringSecurity's Authentication to the UserAccount given.
odrotbohm added a commit that referenced this issue Dec 6, 2021
@odrotbohm
#378 - Polishing.
4ffd0fc 
Cleanups in SpringSecurityAuthenticationManagementUnitTests.
odrotbohm added a commit that referenced this issue Jan 17, 2022
@odrotbohm
#378 - Polishing.
eb6e77e 
Cleanups in SpringSecurityAuthenticationManagementUnitTests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module: orders Orders type: enhancement Improvements and new features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@odrotbohm