Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fields behavior does not conform to Fields extension 1.0.0-rc.3 #469

Open
philvarner opened this issue Apr 25, 2023 · 0 comments
Open

Fields behavior does not conform to Fields extension 1.0.0-rc.3 #469

philvarner opened this issue Apr 25, 2023 · 0 comments
Labels
priority

Comments

@philvarner
Copy link
Collaborator

philvarner commented Apr 25, 2023 •
edited
Loading

There are some conformance problems with the Fields implementation. Most of the warnings and errors below are from the same behavior, just with different combinations of fields, so it's 2 or 3 underlying fixes that resolve them all.

Validator has these warnings:

  • [Item Search - Fields Ext] : GET fields='type' response contained extra fields ['assets', 'bbox', 'geometry', 'links', 'id', 'collection', 'properties']
  • [Item Search - Fields Ext] : GET fields='stac_version' response contained extra fields ['assets', 'bbox', 'geometry', 'links', 'id', 'collection', 'type', 'properties']
  • [Item Search - Fields Ext] : GET fields='id' response contained extra fields ['assets', 'bbox', 'geometry', 'links', 'collection', 'type', 'properties']
  • [Item Search - Fields Ext] : GET fields='geometry' response contained extra fields ['assets', 'bbox', 'links', 'id', 'collection', 'type', 'properties']
  • [Item Search - Fields Ext] : GET fields='bbox' response contained extra fields ['assets', 'geometry', 'links', 'id', 'collection', 'type', 'properties']
  • [Item Search - Fields Ext] : GET fields='links' response contained extra fields ['assets', 'bbox', 'geometry', 'id', 'collection', 'type', 'properties']
  • [Item Search - Fields Ext] : GET fields='assets' response contained extra fields ['bbox', 'geometry', 'links', 'id', 'collection', 'type', 'properties']
  • [Item Search - Fields Ext] : GET fields='+type' response contained extra fields ['assets', 'bbox', 'geometry', 'links', 'id', 'collection', 'properties']
  • [Item Search - Fields Ext] : GET fields='+stac_version' response contained extra fields ['assets', 'bbox', 'geometry', 'links', 'id', 'collection', 'type', 'properties']
  • [Item Search - Fields Ext] : GET fields='+id' response contained extra fields ['assets', 'bbox', 'geometry', 'links', 'collection', 'type', 'properties']
  • [Item Search - Fields Ext] : GET fields='+geometry' response contained extra fields ['assets', 'bbox', 'links', 'id', 'collection', 'type', 'properties']
  • [Item Search - Fields Ext] : GET fields='+bbox' response contained extra fields ['assets', 'geometry', 'links', 'id', 'collection', 'type', 'properties']
  • [Item Search - Fields Ext] : GET fields='+links' response contained extra fields ['assets', 'bbox', 'geometry', 'id', 'collection', 'type', 'properties']
  • [Item Search - Fields Ext] : GET fields='+assets' response contained extra fields ['bbox', 'geometry', 'links', 'id', 'collection', 'type', 'properties']
  • [Item Search - Fields Ext] : POST {'fields': {'include': ['type']}} response contained extra fields ['assets', 'bbox', 'geometry', 'links', 'id', 'collection', 'properties']
  • [Item Search - Fields Ext] : POST {'fields': {'include': ['stac_version']}} response contained extra fields ['assets', 'bbox', 'geometry', 'links', 'id', 'collection', 'type', 'properties']
  • [Item Search - Fields Ext] : POST {'fields': {'include': ['id']}} response contained extra fields ['assets', 'bbox', 'geometry', 'links', 'collection', 'type', 'properties']
  • [Item Search - Fields Ext] : POST {'fields': {'include': ['geometry']}} response contained extra fields ['assets', 'bbox', 'links', 'id', 'collection', 'type', 'properties']
  • [Item Search - Fields Ext] : POST {'fields': {'include': ['bbox']}} response contained extra fields ['assets', 'geometry', 'links', 'id', 'collection', 'type', 'properties']
  • [Item Search - Fields Ext] : POST {'fields': {'include': ['links']}} response contained extra fields ['assets', 'bbox', 'geometry', 'id', 'collection', 'type', 'properties']
  • [Item Search - Fields Ext] : POST {'fields': {'include': ['assets']}} response contained extra fields ['bbox', 'geometry', 'links', 'id', 'collection', 'type', 'properties']
  • [Item Search - Fields Ext] : POST {'fields': {'exclude': ['properties'], 'include': ['properties.eo:cloud_cover']}} response contained extra fields ['assets', 'bbox', 'geometry', 'links', 'id', 'collection', 'type']
  • [Item Search - Fields Ext] : GET fields='+geometry,-geometry' response contained extra fields ['assets', 'bbox', 'links', 'id', 'collection', 'type', 'properties']
  • [Item Search - Fields Ext] : POST {'fields': {'exclude': ['geometry'], 'include': ['geometry']}} response contained extra fields ['assets', 'bbox', 'links', 'id', 'collection', 'type', 'properties']

And these errors:

  • [Item Search - Fields Ext] : GET with empty 'fields' value response missing 'stac_version'
  • [Item Search - Fields Ext] : POST https://earth-search.aws.element84.com/v1/search params=None body={"fields": null} had unexpected status code 200 instead of 400:
  • [Item Search - Fields Ext] : POST with empty 'fields' object value response missing 'stac_version'
  • [Item Search - Fields Ext] : POST with null values for include and exclude response missing 'stac_version'
  • [Item Search - Fields Ext] : POST with empty arrays for include and exclude response missing 'stac_version'
  • [Item Search - Fields Ext] : GET fields='type' response contained more than 5 extra fields ['assets', 'bbox', 'geometry', 'links', 'id', 'collection', 'type', 'properties']
  • [Item Search - Fields Ext] : GET fields='stac_version' response contained more than 5 extra fields ['stac_version', 'assets', 'bbox', 'geometry', 'links', 'id', 'collection', 'type', 'properties']
  • [Item Search - Fields Ext] : GET fields='id' response contained more than 5 extra fields ['assets', 'bbox', 'geometry', 'links', 'id', 'collection', 'type', 'properties']
  • [Item Search - Fields Ext] : GET fields='geometry' response contained more than 5 extra fields ['assets', 'bbox', 'geometry', 'links', 'id', 'collection', 'type', 'properties']
  • [Item Search - Fields Ext] : GET fields='bbox' response contained more than 5 extra fields ['assets', 'bbox', 'geometry', 'links', 'id', 'collection', 'type', 'properties']
  • [Item Search - Fields Ext] : GET fields='links' response contained more than 5 extra fields ['assets', 'bbox', 'geometry', 'links', 'id', 'collection', 'type', 'properties']
  • [Item Search - Fields Ext] : GET fields='assets' response contained more than 5 extra fields ['assets', 'bbox', 'geometry', 'links', 'id', 'collection', 'type', 'properties']
  • [Item Search - Fields Ext] : GET fields='+type' response contained more than 5 extra fields ['assets', 'bbox', 'geometry', 'links', 'id', 'collection', 'type', 'properties']
  • [Item Search - Fields Ext] : GET fields='+stac_version' response missing 'stac_version'
  • [Item Search - Fields Ext] : GET fields='+stac_version' response contained more than 5 extra fields ['assets', 'bbox', 'geometry', 'links', 'id', 'collection', 'type', 'properties']
  • [Item Search - Fields Ext] : GET fields='+id' response contained more than 5 extra fields ['assets', 'bbox', 'geometry', 'links', 'id', 'collection', 'type', 'properties']
  • [Item Search - Fields Ext] : GET fields='+geometry' response contained more than 5 extra fields ['assets', 'bbox', 'geometry', 'links', 'id', 'collection', 'type', 'properties']
  • [Item Search - Fields Ext] : GET fields='+bbox' response contained more than 5 extra fields ['assets', 'bbox', 'geometry', 'links', 'id', 'collection', 'type', 'properties']
  • [Item Search - Fields Ext] : GET fields='+links' response contained more than 5 extra fields ['assets', 'bbox', 'geometry', 'links', 'id', 'collection', 'type', 'properties']
  • [Item Search - Fields Ext] : GET fields='+assets' response contained more than 5 extra fields ['assets', 'bbox', 'geometry', 'links', 'id', 'collection', 'type', 'properties']
  • [Item Search - Fields Ext] : POST {'fields': {'include': ['type']}} response contained more than 5 extra fields ['assets', 'bbox', 'geometry', 'links', 'id', 'collection', 'type', 'properties']
  • [Item Search - Fields Ext] : POST {'fields': {'include': ['stac_version']}} response contained more than 5 extra fields ['stac_version', 'assets', 'bbox', 'geometry', 'links', 'id', 'collection', 'type', 'properties']
  • [Item Search - Fields Ext] : POST {'fields': {'include': ['id']}} response contained more than 5 extra fields ['assets', 'bbox', 'geometry', 'links', 'id', 'collection', 'type', 'properties']
  • [Item Search - Fields Ext] : POST {'fields': {'include': ['geometry']}} response contained more than 5 extra fields ['assets', 'bbox', 'geometry', 'links', 'id', 'collection', 'type', 'properties']
  • [Item Search - Fields Ext] : POST {'fields': {'include': ['bbox']}} response contained more than 5 extra fields ['assets', 'bbox', 'geometry', 'links', 'id', 'collection', 'type', 'properties']
  • [Item Search - Fields Ext] : POST {'fields': {'include': ['links']}} response contained more than 5 extra fields ['assets', 'bbox', 'geometry', 'links', 'id', 'collection', 'type', 'properties']
  • [Item Search - Fields Ext] : POST {'fields': {'include': ['assets']}} response contained more than 5 extra fields ['assets', 'bbox', 'geometry', 'links', 'id', 'collection', 'type', 'properties']
  • [Item Search - Fields Ext] : POST {'fields': {'exclude': ['geometry']}} response missing 'properties.eo:cloud_cover'
  • [Item Search - Fields Ext] : GET fields='-properties,+properties.eo:cloud_cover' response contained 'geometry', but should have been excluded
  • [Item Search - Fields Ext] : GET fields='-properties,+properties.eo:cloud_cover' response missing 'properties.eo:cloud_cover'
  • [Item Search - Fields Ext] : POST {'fields': {'exclude': ['properties'], 'include': ['properties.eo:cloud_cover']}} response contained 'geometry', but should have been excluded
  • [Item Search - Fields Ext] : POST {'fields': {'exclude': ['properties'], 'include': ['properties.eo:cloud_cover']}} response missing 'properties.eo:cloud_cover'
  • [Item Search - Fields Ext] : POST {'fields': {'exclude': ['properties'], 'include': ['properties.eo:cloud_cover']}} response contained more than 5 extra fields ['assets', 'bbox', 'geometry', 'links', 'id', 'collection', 'type']
  • [Item Search - Fields Ext] : GET fields='+geometry,-geometry' response missing 'geometry'
  • [Item Search - Fields Ext] : GET fields='+geometry,-geometry' response contained more than 5 extra fields ['assets', 'bbox', 'links', 'id', 'collection', 'type', 'properties']
  • [Item Search - Fields Ext] : POST {'fields': {'exclude': ['geometry'], 'include': ['geometry']}} response missing 'geometry'
  • [Item Search - Fields Ext] : POST {'fields': {'exclude': ['geometry'], 'include': ['geometry']}} response contained more than 5 extra fields ['assets', 'bbox', 'links', 'id', 'collection', 'type', 'properties']
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@philvarner