Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create API module #199

Open
jisantuc opened this issue Dec 29, 2020 · 1 comment
Open

Create API module #199

jisantuc opened this issue Dec 29, 2020 · 1 comment

Comments

@jisantuc
Copy link
Contributor

jisantuc commented Dec 29, 2020 •
edited
Loading

Improvement

#140 adds a bunch of models for interacting with APIs. Some of these are copied directly from Franklin. We should create an API module to hold the shared types and have Franklin and the client depend on those for their client/server implementations instead of maintaining the code in two places.
@jisantuc jisantuc mentioned this issue Dec 29, 2020
Merged
2 tasks
@pomadchin
Copy link
Collaborator

pomadchin commented May 21, 2021 •
edited
Loading

To make it a bit more concrete: we talk here about these models as well, in particular it could be nice to have the following STAC API models:

  • PaginationToken (backported into stac4s client)
  • Query (backported into stac4s client)
  • StacSearchCollection (right now I workaround it via focusing on fields we need for the request)
  • CollectionItemsResponse (right now I workaround it via focusing on fields we need for the request)

@pomadchin pomadchin mentioned this issue May 21, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pomadchin @jisantuc