Account for nil values in OAuth configuration (#4510)

A recent change ended up initializing them. This ensure that we deal with these initialized values. Signed-off-by: Juan Antonio Osorio <[email protected]>
mindersec · Sep 17, 2024 · 6f89a1d · 6f89a1d
1 parent dc1b896
commit 6f89a1d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/internal/providers/github/manager/manager.go b/internal/providers/github/manager/manager.go
@@ -366,7 +366,7 @@ func (g *githubProviderManager) NewOAuthConfig(providerClass db.ProviderClass, c
 	}
 
 	// this is currently only used for testing as github uses well-known endpoints
-	if oauthClientConfig.Endpoint != nil {
+	if oauthClientConfig.Endpoint != nil && oauthClientConfig.Endpoint.TokenURL != "" {
 		oauthConfig.Endpoint = oauth2.Endpoint{
 			TokenURL: oauthClientConfig.Endpoint.TokenURL,
 		}

diff --git a/internal/providers/gitlab/manager/auth.go b/internal/providers/gitlab/manager/auth.go
@@ -42,7 +42,7 @@ func (g *providerClassManager) NewOAuthConfig(_ db.ProviderClass, cli bool) (*oa
 	}
 
 	// this is currently only used for testing as github uses well-known endpoints
-	if oauthClientConfig.Endpoint != nil {
+	if oauthClientConfig.Endpoint != nil && oauthClientConfig.Endpoint.TokenURL != "" {
 		oauthConfig.Endpoint = oauth2.Endpoint{
 			TokenURL: oauthClientConfig.Endpoint.TokenURL,
 		}