Skip to content

Commit

Permalink
Fix missing slash in github webhook path (#4479)
Browse files Browse the repository at this point in the history
The slash was missing and is the reason we were getting:

```
2024/09/13 11:30:01 ERROR: Failed to extract ServerMetadata from context
```

Signed-off-by: Juan Antonio Osorio <[email protected]>
  • Loading branch information
JAORMX authored Sep 13, 2024
1 parent 6829aa5 commit ab008d7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion internal/controlplane/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ func (s *Server) StartHTTPServer(ctx context.Context) error {
}

// This requires explicit middleware. CORS is not required here.
mux.Handle("/api/v1/webhook/github", otelmw(withMiddleware(s.HandleGitHubWebHook())))
mux.Handle("/api/v1/webhook/github/", otelmw(withMiddleware(s.HandleGitHubWebHook())))
mux.Handle("/api/v1/ghapp/", otelmw(withMiddleware(s.HandleGitHubAppWebhook())))
mux.Handle("/api/v1/gh-marketplace/", otelmw(withMiddleware(s.NoopWebhookHandler())))
mux.Handle("/static/", fs)
Expand Down

0 comments on commit ab008d7

Please sign in to comment.