Dual write rule instances to new and old tables (#3486)

Relates to #3485

Any time a profile is created or updated, write the rule instances to
both the new and old rule instance tables. Mark the entries in the old
tables as migrated so that we skip over them when we run the migration
process.

Also made def/params field nullable.

database/migrations/000061_rule_instance_not_null_def.down.sql

@@ -0,0 +1,20 @@
+-- Copyright 2024 Stacklok, Inc
+--
+-- Licensed under the Apache License, Version 2.0 (the "License");
+-- you may not use this file except in compliance with the License.
+-- You may obtain a copy of the License at
+--
+--      http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+
+BEGIN;
+
+ALTER TABLE rule_instances ALTER COLUMN def DROP NOT NULL;
+ALTER TABLE rule_instances ALTER COLUMN params DROP NOT NULL;
+
+COMMIT;

database/migrations/000061_rule_instance_not_null_def.up.sql

@@ -0,0 +1,20 @@
+-- Copyright 2024 Stacklok, Inc
+--
+-- Licensed under the Apache License, Version 2.0 (the "License");
+-- you may not use this file except in compliance with the License.
+-- You may obtain a copy of the License at
+--
+--      http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+
+BEGIN;
+
+ALTER TABLE rule_instances ALTER COLUMN def SET NOT NULL;
+ALTER TABLE rule_instances ALTER COLUMN params SET NOT NULL;
+
+COMMIT;

database/query/profiles.sql

@@ -28,7 +28,7 @@ INSERT INTO entity_profiles (
     $1,
     $2,
     sqlc.arg(contextual_rules)::jsonb,
-    FALSE
+    TRUE
 ) RETURNING *;
 
 -- name: UpsertProfileForEntity :one
@@ -40,7 +40,7 @@ INSERT INTO entity_profiles (
 ) VALUES ($1, $2, sqlc.arg(contextual_rules)::jsonb, false)
 ON CONFLICT (entity, profile_id) DO UPDATE SET
     contextual_rules = sqlc.arg(contextual_rules)::jsonb,
-    migrated = FALSE
+    migrated = TRUE
 RETURNING *;
 
 -- name: DeleteProfileForEntity :exec
@@ -110,7 +110,7 @@ GROUP BY profiles.id;
 -- name: CountProfilesByEntityType :many
 SELECT COUNT(p.id) AS num_profiles, ep.entity AS profile_entity
 FROM profiles AS p
-         JOIN entity_profiles AS ep ON p.id = ep.profile_id
+JOIN entity_profiles AS ep ON p.id = ep.profile_id
 GROUP BY ep.entity;
 
 -- name: CountProfilesByName :one

database/query/rule_instances.sql

@@ -0,0 +1,52 @@
+-- Copyright 2024 Stacklok, Inc
+--
+-- Licensed under the Apache License, Version 2.0 (the "License");
+-- you may not use this file except in compliance with the License.
+-- You may obtain a copy of the License at
+--
+--      http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+
+-- name: UpsertRuleInstance :one
+INSERT INTO rule_instances (
+    profile_id,
+    rule_type_id,
+    name,
+    entity_type,
+    def,
+    params,
+    created_at,
+    updated_at
+) VALUES(
+    $1,
+    $2,
+    $3,
+    $4,
+    $5,
+    $6,
+    NOW(),
+    NOW()
+)
+ON CONFLICT (profile_id, entity_type, name) DO UPDATE SET
+    rule_type_id = $2,
+    def = $5,
+    params = $6,
+    updated_at = NOW()
+RETURNING id;
+
+-- name: GetRuleInstancesForProfile :many
+SELECT * FROM rule_instances WHERE profile_id = $1;
+
+-- name: GetRuleInstancesForProfileEntity :many
+SELECT * FROM rule_instances WHERE profile_id = $1 AND entity_type = $2;
+
+-- name: DeleteNonUpdatedRules :exec
+DELETE FROM rule_instances
+WHERE profile_id = $1
+AND entity_type = $2
+AND NOT id = ANY(sqlc.arg(updated_ids)::UUID[]);