Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change fuzzing test to avoid leaving files around #3539

Merged
merged 3 commits into from
Jun 5, 2024
Merged

Conversation

dmjb
Copy link
Contributor

@dmjb dmjb commented Jun 5, 2024

The previous implementation would create a test file but never clean it up, which causes problems when running the tests locally.

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@dmjb dmjb requested a review from a team as a code owner June 5, 2024 13:30
blkt
blkt previously approved these changes Jun 5, 2024
@dmjb
Copy link
Contributor Author

dmjb commented Jun 5, 2024

FYI @AdamKorcz

blkt
blkt previously approved these changes Jun 5, 2024
dmjb added 3 commits June 5, 2024 14:44
The previous implementation would create a test file but never clean it
up, which causes problems when running the tests locally.
@dmjb dmjb merged commit d986b0c into main Jun 5, 2024
21 checks passed
@dmjb dmjb deleted the remove-test-dir branch June 5, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants