Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable multi-arch testing for konflux images #1768

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

Stringy
Copy link
Collaborator

@Stringy Stringy commented Aug 1, 2024

Description

Simply removes guards from tests, to allow running konflux images on multi-arch VMs.

Checklist

  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • Added unit tests
  • Added integration tests
  • Added regression tests

If any of these don't apply, please comment below.

Testing Performed

TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why you did not do so. (Valid reasons include "CI is sufficient" or "No testable changes")
In addition to reviewing your code, reviewers must also review your testing instructions, and make sure they are sufficient.

For more details, ref the Confluence page about this section.

@Stringy Stringy added the run-multiarch-builds Run steps for non-x86 archs. label Aug 1, 2024
@Stringy Stringy requested a review from a team as a code owner August 1, 2024 11:56
.github/workflows/integration-tests.yml Outdated Show resolved Hide resolved
.github/workflows/integration-tests.yml Outdated Show resolved Hide resolved
.github/workflows/integration-tests.yml Outdated Show resolved Hide resolved
@Stringy Stringy requested a review from Molter73 August 1, 2024 13:56
Copy link
Collaborator

@Molter73 Molter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided CI passes, LGTM!

@Stringy
Copy link
Collaborator Author

Stringy commented Aug 1, 2024

/retest

@Stringy Stringy merged commit 923f1c2 into master Aug 2, 2024
61 of 62 checks passed
@Stringy Stringy deleted the giles/multi-arch-konflux-tests branch August 2, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-multiarch-builds Run steps for non-x86 archs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants