Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index PDF and MS Office documents #2

Open
mdecimus opened this issue Sep 15, 2022 · 5 comments
Open

Index PDF and MS Office documents #2

mdecimus opened this issue Sep 15, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@mdecimus
Copy link
Member

There is poor support in the Rust ecosystem for extracting text from PDF and MsOffice documents.
Look for alternatives.

@mdecimus mdecimus added the enhancement New feature or request label Sep 15, 2022
@dumblob
Copy link

dumblob commented Oct 4, 2022

On one hand this is a useful feature. I see though one important issue with it though. And it is so much important that there should be a checkbox to disable this feature.

Namely this "content indexing" is largely unreliable in practice. Documents are super wild in their formats, producers, etc. that one can not guarantee proper indexing of them. But it gets much worse realizing that only a tiny subset of document types/formats can be indexed. Once a user finds out a document got indexed she automatically assumes all (incl. every single existing format ever made on this planet) will be indexed and searchable. Nothing is more distant from reality than this.

To sum up:

  1. content indexing is useful
  2. content indexing has to be optional (default on - but see point (3))
  3. content indexing has to be fully explicit in the user-facing UI - namely when searching a mail box there has to be a checkbox explicitly listing document formats to be searched through their content

@yodatak
Copy link

yodatak commented Nov 18, 2022

Hello we could use a interface of ripgrep or ripgrepall i use It for search in pdf and docs

@yodatak
Copy link

yodatak commented Nov 18, 2022

@cptspff
Copy link

cptspff commented Dec 12, 2022

How about supporting attachment parsing with an optional external solution like TikaServer? It's easy to implement, battle-tested and relatively complete.

Also, it's probably a good idea to offer a "limit content indexing to known contacts" setting due to the inherently risky business of content scanning. It's my understanding jmap-server will handle contacts as well in the future - please correct me if I'm wrong.

@mdecimus
Copy link
Member Author

@cptspff and @yodatak I want to avoid using external software (unless these are available as libraries) since that will require users to install and maintain yet another component. But I am going to take a look at Tika and ripgrep to see how they're doing it, perhaps they have some of their functionality available as a library. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants