Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a clean alert/confirm dialog #178

Open
jadrake75 opened this issue Jan 9, 2022 · 1 comment
Open

Implement a clean alert/confirm dialog #178

jadrake75 opened this issue Jan 9, 2022 · 1 comment
Assignees
@jadrake75
Labels
enhancement

Comments

@jadrake75
Copy link
Contributor

With migration to Bootstrap 5, bootbox no longer works. There is a need for a cleaner alert/confirm dialog. See code and search for window.alert and window.confirm cases (there is ~ 5)
@jadrake75 jadrake75 self-assigned this Jan 9, 2022
jadrake75 added a commit that referenced this issue Jan 9, 2022
@jadrake75
Upgrade to Bootstrap and Rework Test Infrastructure
ae34e48 
* Upgrade to Bootstrap 5
* Replace jasmine/karma with jest
* Reduce drastically the security vulnerabilities in libraries
* Had to remove Bootbox - reversion to alert/confirm see #178
* Fixed the date picker where dates were not setting set on edit
* Updated to use dart-sass instead of node-sass
* Redid boostrap + theme generation
Causes #181 #179

Fixes #145 #108 #175 #177 #180
@jadrake75
Copy link
Contributor Author

Here is the current dialog using just the window.confirm and window.alert

image

Shouldn't be too hard to provide something better, although it should take on the same general look, only with a title and proper centering

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jadrake75 jadrake75

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jadrake75