Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add amazon bedrock 3p models to the model configuration. #2967

Open
subhaviv opened this issue Sep 3, 2024 · 2 comments
Open

Add amazon bedrock 3p models to the model configuration. #2967

subhaviv opened this issue Sep 3, 2024 · 2 comments

Comments

@subhaviv
Copy link
Contributor

subhaviv commented Sep 3, 2024

I want to add bedrock 3rd party models to the list of models available . Will use the Bedrock Client API's from the model providers if they have them((Anthropic, Cohere and A121 ), Otherwise create one like the one for Titan. What are your thoughts?

@yifanmai
Copy link
Collaborator

yifanmai commented Sep 3, 2024

Yes, I think it would be good to add the Bedrock models. In general, you would subclass the respective client in HELM (e.g. AnthropicClient) and modify it to connect to Bedrock. See here for the respective docs:

Also refer to #1713 for some previous notes.

@subhaviv
Copy link
Contributor Author

subhaviv commented Sep 6, 2024

I added Mistral and LLAMA3 models on bedrock and submitted a PR. I will add the other 3 models next week. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants