Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In weather agent responses, the default location should be a city #285

Closed
s-jse opened this issue Mar 6, 2021 · 2 comments
Closed

In weather agent responses, the default location should be a city #285

s-jse opened this issue Mar 6, 2021 · 2 comments

Comments

@s-jse
Copy link
Member

s-jse commented Mar 6, 2021

I think in previous versions, the agent would reply by using the city name, e.g. Stanford.

U: what is the weather like?
UT: $dialogue @org.thingpedia.dialogue.transaction.execute;
UT: @org.thingpedia.weather.current();
C: $dialogue @org.thingpedia.dialogue.transaction.execute;
C: @org.thingpedia.weather.current(location=new Location(37.433014400000005, -122.17087506623025, "Cantor Arts Center"))
C: #[results=[
C:   { temperature=14.1C, wind_speed=2.9mps, humidity=50.8, cloudiness=20.3, fog=0, status=enum cloudy, icon="http://api.met.no/weatherapi/weathericon/1.1/?symbol=2;content_type=image/png"^^tt:picture, location=new Location(37.433014400000005, -122.17087506623025, "Cantor Arts Center") }
C: ]];
A: It is cloudy today in Cantor Arts Center and the temperature is 57.4 F.
AT: $dialogue @org.thingpedia.dialogue.transaction.sys_display_result;
@s-jse
Copy link
Member Author

s-jse commented Mar 6, 2021

I think we should add some form of automatic tests for some simple commands like this.

@gcampax
Copy link
Contributor

gcampax commented Mar 8, 2021

The agent replies with whatever is the name of the stored or retrieved current location (whether stored or retrieved depends on the platform, although I think only Android ever supported GPS location). A related issue is stanford-oval/thingtalk#319 but I don't think we want to change the weather skill.

@gcampax gcampax closed this as completed Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants