Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate Netlify preview inaccuracies #750

Closed
penovicp opened this issue Sep 11, 2023 · 2 comments
Closed

Investigate Netlify preview inaccuracies #750

penovicp opened this issue Sep 11, 2023 · 2 comments
Assignees
@penovicp
Labels
CI

Comments

@penovicp
Copy link
Collaborator

The Netlify preview build seems to be inaccurate.

For PR #747 the JSDOC description changes for e.g. isCairo1Abi should read Test if an ABI comes from a Cairo 1 contract, however, the older tells if an ABI comes from a Cairo 1 contract is displayed.
@penovicp penovicp added the CI label Sep 11, 2023
@penovicp penovicp self-assigned this Sep 11, 2023
@tabaktoni
Copy link
Collaborator

What is status on this ?

@penovicp
Copy link
Collaborator Author

I think it might have been resolved by #781. Haven't come up with a test to fully confirm it.

@penovicp penovicp closed this as completed Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@penovicp penovicp

Labels
CI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tabaktoni @penovicp