Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LS: Ignore warning diagnostics from deps and macro generated files #6310

Open
Arcticae opened this issue Aug 29, 2024 · 0 comments
Open

LS: Ignore warning diagnostics from deps and macro generated files #6310

Arcticae opened this issue Aug 29, 2024 · 0 comments
Labels
ide This issue refers to CairoLS or editor extensions

Comments

@Arcticae
Copy link
Collaborator

Arcticae commented Aug 29, 2024 •
edited by Draggu
Loading

Currently we are showing warning diagnostics from dependencies, they should be ignored

Scarb has added this behavior recently: #6279

Also we can skip warns from virtual files generated by macros
@Arcticae Arcticae added the ide This issue refers to CairoLS or editor extensions label Aug 29, 2024
@Draggu Draggu changed the title LS: Ignore warning diagnostics from deps LS: Ignore warning diagnostics from deps and macro generated files Aug 30, 2024
Draggu added a commit that referenced this issue Sep 5, 2024
@Draggu
LS: Skip warnings in deps
1524391 
fix #6310

commit-id:4536ca03
@Draggu Draggu mentioned this issue Sep 5, 2024
Closed
Draggu added a commit that referenced this issue Sep 5, 2024
@Draggu
LS: Skip warnings in deps
675ec0f 
fix #6310

commit-id:4536ca03
Draggu added a commit that referenced this issue Sep 5, 2024
@Draggu
LS: Skip warnings in deps
568de77 
fix #6310

commit-id:4536ca03
Draggu added a commit that referenced this issue Sep 5, 2024
@Draggu
LS: Skip warnings in deps
44c0b23 
fix #6310

commit-id:4536ca03
@Arcticae Arcticae mentioned this issue Sep 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ide This issue refers to CairoLS or editor extensions
Projects
CairoLS
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

LS: Skip warnings in deps starkware-libs/cairo
2 participants
@Arcticae @Draggu