Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image links broken in share cards #12

Closed
genebean opened this issue Jan 18, 2023 · 4 comments
Closed

Image links broken in share cards #12

genebean opened this issue Jan 18, 2023 · 4 comments

Comments

@genebean
Copy link
Contributor

It seems building a site causes files like assets/images/foo.png to be converted to webp but the templates for twitter:image and og:image don’t account for this. They are still looking for /images/foo.png, which 404’s.
@tfsojon
Copy link
Contributor

tfsojon commented Jan 19, 2023

Hello @genebean
We published a new version of iWriter. This Issue is solved with new release v2.0.0

@tfsojon tfsojon closed this as completed Jan 19, 2023
@genebean
Copy link
Contributor Author

@tfsojon it appears some amount of work is needed for exiting users to update to v2.0.0 based on this PR by dependabot failing to build on Netlify. Are there any docs on how to go about updating?

@genebean
Copy link
Contributor Author

I ended up filing #13 about this issue @tfsojon

@tfsojon
Copy link
Contributor

tfsojon commented Jan 21, 2023

@genebean As you can see v2.0.0 is a huge upgrade so creating a step by step upgrade guide will be quite messy. For now please follow the Commits on Jan 19, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@genebean @tfsojon