Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEPs are constant one for certain inputs #28

Open
ezander opened this issue Jul 23, 2024 · 1 comment
Open

PEPs are constant one for certain inputs #28

ezander opened this issue Jul 23, 2024 · 1 comment

Comments

@ezander
Copy link

ezander commented Jul 23, 2024

For certain inputs of scores and targets the peps computed by getQvaluesFromScores are all one. This is due to the monotonization step at the end of the function (line 81, probs = monotonize(probs)).

I've created a fork at https://github.com/ezander/triqler and added two files (data.py and issue.py) in https://github.com/ezander/triqler/tree/issue/pep_constant_one/tests/issue that demonstrate the issue.

@RalfG
Copy link

RalfG commented Aug 14, 2024

We have also seen this happening when the highest scoring PSM is a decoy. As a workaround (but obviously not a fix), such decoy PSMs could be removed from the dataset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants