Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement withdraw "backdoor" for accidentally sent tokens to community vaults #54

Closed
0x-r4bbit opened this issue Feb 26, 2024 · 0 comments · Fixed by #59
Closed

Implement withdraw "backdoor" for accidentally sent tokens to community vaults #54

0x-r4bbit opened this issue Feb 26, 2024 · 0 comments · Fixed by #59

Comments

@0x-r4bbit
Copy link
Member

Once #31 is implemented, the vaults will essentially have their own accounting.
This however, obviously doesn't prevent anyone from sending tokens to the vault contract directly.

Assuming that the vault's transferERC20 and transfer721 tokens will operate on the internal accounting, tokens sent directly to the contract without the dedicated deposit functions will lock those tokens forever.

This is why we should consider adding some sort of "backdoor" that enables community owners (or who ever has the privelege), to withdraw any excess tokens from the vault.

Feel free to comment here on why this might not be a good idea.

@0xb337r007 @3esmit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants