Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a "Dismissed contact requests" tab in the Contacts panel #16844

Closed
jrainville opened this issue Nov 28, 2024 · 0 comments · Fixed by #17021
Closed

Add a "Dismissed contact requests" tab in the Contacts panel #16844

jrainville opened this issue Nov 28, 2024 · 0 comments · Fixed by #17021
Assignees
@jrainville
Labels
core-team Desktop Contact Requests E:Desktop Contact Requests Anything related to mutual contacts and sending/receiving contact requests feature goal:core:P0:messaging_active_users
Milestone
2.33.0 Beta

Comments

@jrainville
Copy link
Member

Description

This was discussed here: #16817 (comment)

Basically, we want to have a new tab in the Contacts Panel similar to what we have in the Community Members panel where people that have been "rejected"/"dismissed" appear.
Then, you can "undo" the dismissal.

In the case of the dismissed contact request, clicking the "undo" (text TBD) button would send an Accept to the original contact request. The result being the same as if you approved without dismissing.

Acceptance Criteria

  • When a contact request is dismissed, the contact goes from the "Pending" list to the "Dismissed" list in the Contacts panel in the Settings
  • The AC notification shows as Dismissed (as we currently do)
  • In the "Dismissed" tab, you have an "undo" button (text TBD)
  • Clicking that button acts as if we clicked "Accept" without having dismissed
  • The end result is the same as if "Accept" was clicked, ie both are mutual, the 1-1 chat is opened. AC notification is changed to Accepted
@jrainville jrainville added core-team Desktop Contact Requests E:Desktop Contact Requests Anything related to mutual contacts and sending/receiving contact requests feature labels Nov 28, 2024
@jrainville jrainville added this to the 2.33.0 Beta milestone Nov 28, 2024
@jrainville jrainville mentioned this issue Nov 28, 2024
Closed
@jrainville jrainville self-assigned this Jan 3, 2025
@jrainville jrainville moved this to In Progress in Status Desktop/Mobile Board Jan 3, 2025
jrainville added a commit that referenced this issue Jan 3, 2025
@jrainville
feat(contacts): add a tab for dismissed contacts and a button to undo
7ccf7d2 
Fixes #16844

Adds a tab in the Messaging>Contacts page that shows the dismissed contact requests.
it has a button to undo the rejection. That is simply a call to accept the old contact request, which then makes the two users mutual contacts
@jrainville jrainville mentioned this issue Jan 3, 2025
Merged
3 tasks
@jrainville jrainville moved this from In Progress to Code Review in Status Desktop/Mobile Board Jan 3, 2025
jrainville added a commit that referenced this issue Jan 6, 2025
@jrainville
feat(contacts): add a tab for dismissed contacts and a button to undo
be12287 
Fixes #16844

Adds a tab in the Messaging>Contacts page that shows the dismissed contact requests.
it has a button to undo the rejection. That is simply a call to accept the old contact request, which then makes the two users mutual contacts
jrainville added a commit that referenced this issue Jan 8, 2025
@jrainville
feat(contacts): add a tab for dismissed contacts and a button to undo
8d093e2 
Fixes #16844

Adds a tab in the Messaging>Contacts page that shows the dismissed contact requests.
it has a button to undo the rejection. That is simply a call to accept the old contact request, which then makes the two users mutual contacts
jrainville added a commit that referenced this issue Jan 13, 2025
@jrainville
feat(contacts): add a tab for dismissed contacts and a button to undo
bd338bb 
Fixes #16844

Adds a tab in the Messaging>Contacts page that shows the dismissed contact requests.
it has a button to undo the rejection. That is simply a call to accept the old contact request, which then makes the two users mutual contacts
jrainville added a commit that referenced this issue Jan 14, 2025
@jrainville
feat(contacts): add a tab for dismissed contacts and a button to undo
1295d9a 
Fixes #16844

Adds a tab in the Messaging>Contacts page that shows the dismissed contact requests.
it has a button to undo the rejection. That is simply a call to accept the old contact request, which then makes the two users mutual contacts
jrainville added a commit that referenced this issue Jan 14, 2025
@jrainville
Add a "Dismissed contact requests" tab in the Contacts panel (#17021)
a6e6546 
* chore(ContactPanel): add tooltips to contact panel buttons

* feat(contacts): add a tab for dismissed contacts and a button to undo

Fixes #16844

Adds a tab in the Messaging>Contacts page that shows the dismissed contact requests.
it has a button to undo the rejection. That is simply a call to accept the old contact request, which then makes the two users mutual contacts
@github-project-automation github-project-automation bot moved this from Code Review to Done in Status Desktop/Mobile Board Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrainville jrainville

Labels
core-team Desktop Contact Requests E:Desktop Contact Requests Anything related to mutual contacts and sending/receiving contact requests feature goal:core:P0:messaging_active_users
Projects
Status Desktop/Mobile Board
Status: Done
Milestone
2.33.0 Beta
Development

Successfully merging a pull request may close this issue.

Add a "Dismissed contact requests" tab in the Contacts panel status-im/status-desktop
1 participant
@jrainville