Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log rotate #229

Closed
MarinX opened this issue Aug 3, 2017 · 3 comments · Fixed by status-im/status-mobile#2830
Closed

Log rotate #229

MarinX opened this issue Aug 3, 2017 · 3 comments · Fixed by status-im/status-mobile#2830

Comments

@MarinX
Copy link
Contributor

MarinX commented Aug 3, 2017

Currently, go-ethereum log package does not support log rotating which can be issue on mobile devices.

The go-ethereum logger depends on the package log15

@tiabc
Copy link
Contributor

tiabc commented Oct 25, 2017

@rasom do we allow status-go log output on mobile devices at all?

@pedropombeiro
Copy link
Contributor

Regarding log15 and log rotation, this might be useful: inconshreveable/log15#133

@tiabc I wouldn't mind picking this up, but am wondering why this has been open for such a long time.

@pedropombeiro
Copy link
Contributor

I'm almost finished with this GHI, just in case. It seems that geth log output is disabled by default by status-react: https://github.com/status-im/status-react/blob/develop/modules/react-native-status/android/src/main/java/im/status/ethereum/module/StatusModule.java#L180. I've asked a question related to another PR of mine, in case we want to enable geth logging by default, now that the level can be controlled independently by a feature flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants