Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: add support for computing the secant (sec) #225

Open
3 tasks done
kgryte opened this issue Oct 23, 2018 · 16 comments · May be fixed by #2920
Open
3 tasks done

RFC: add support for computing the secant (sec) #225

kgryte opened this issue Oct 23, 2018 · 16 comments · May be fixed by #2920
Assignees
@fady228
Labels
difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! Help Wanted Extra attention is needed. Math Issue or pull request specific to math functionality. RFC Request for comments. Feature requests and proposed changes.

Comments

@kgryte
Copy link
Member

kgryte commented Oct 23, 2018

Checklist

Please ensure the following tasks are completed before submitting a feature request.

  • Read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.

Description

Description of the feature request.

This RFC proposes adding support for computing the secant. The initial implementation is straightforward:

return 1.0 / cos( x );

Package: @stdlib/math/base/special/sec
Alias: base.sec

Related Issues

Does this feature request have any related issues?

No.

Questions

Any questions for reviewers?

No.

Other

Any other information relevant to this feature request? This may include screenshots, references, sample output, and/or implementation notes.

Reference implementations:
@kgryte kgryte added Help Wanted Extra attention is needed. RFC Request for comments. Feature requests and proposed changes. Feature Issue or pull request for adding a new feature. difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Math Issue or pull request specific to math functionality. Good First Issue A good first issue for new contributors! labels Oct 23, 2018
@kgryte kgryte changed the title RFC: add support for computing the secant RFC: add support for computing the secant (sec) Oct 23, 2018
@Tranced
Copy link

Tranced commented Sep 30, 2019

Would be great if you could assign this to me. The other mathematical functions seem like low hanging fruit too but it would be better to knock out one first.

@Planeshifter
Copy link
Member

Awesome, thanks for your willingness to work on this! Just assigned you.

@kgryte
Copy link
Member Author

kgryte commented Sep 30, 2019

@Tranced See acoth for a package on which you can model your implementation.

@kgryte
Copy link
Member Author

kgryte commented Jun 28, 2020

Unassigning this issue so other contributors can feel free to work on this.

@yashshah1
Copy link

Can I work on this?

@kgryte
Copy link
Member Author

kgryte commented Aug 26, 2020

@yashshah1 Sure! Go for it! Feel free to ping here or on Gitter if you encounter any issues or have any questions!

mhmdaminraeisi added a commit to mhmdaminraeisi/stdlib that referenced this issue Feb 4, 2022
@mhmdaminraeisi
Fix issue stdlib-js#225.
98b2e60
@mhmdaminraeisi mhmdaminraeisi mentioned this issue Feb 4, 2022
Closed
1 task
@Hritik1503

This comment was marked as spam.

Sign in to view
@fady228
Copy link

fady228 commented Feb 26, 2024

@kgryte @Planeshifter assign this issue to me please

@Planeshifter
Copy link
Member

@fady228 Sure, thanks for looking into adding this package!

@AbhijitRaut04
Copy link

@Planeshifter Is this issue open currently?

@Planeshifter
Copy link
Member

@AbhijitRaut04 The package has not been added to stdlib (nor is there an open PR) and we have moved away from assigning issues, so please feel free to send a PR! Looking forward to your contribution!

@AbhijitRaut04
Copy link

@Planeshifter I am a beginner. I have cloned repo after forking into my environment. I am little bit confused about where to write my code. So, Can you please tell me where to write code about this secant function?

@Planeshifter
Copy link
Member

@AbhijitRaut04 The code should live in the lib/node_modules/@stdlib/math/base/special/sec directory.

@AbhijitRaut04
Copy link

how can i use the functions sin, cos, tan ?

@kgryte
Copy link
Member Author

kgryte commented Sep 16, 2024

@AbhijitRaut04 I suggest spending some time reading the code of other packages in @stdlib/math/base/special. There are plenty of examples of packages using the functionality you describe.

@AbhijitRaut04 AbhijitRaut04 linked a pull request Sep 18, 2024 that will close this issue
Open
1 task
@AbhijitRaut04
Copy link

@Planeshifter
@kgryte
I have raised PR, are there any changes required for secant function ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fady228 fady228

Labels
difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! Help Wanted Extra attention is needed. Math Issue or pull request specific to math functionality. RFC Request for comments. Feature requests and proposed changes.
Projects
None yet
Milestone
No milestone
7 participants
@Planeshifter @kgryte @Tranced @yashshah1 @Hritik1503 @fady228 @AbhijitRaut04