-
-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add C implementation for stats/base/dists/binomial/variance
#3929
Conversation
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
Coverage Report
The above coverage report was generated for the changes in this PR. |
/stdlib update-copyright-years |
stats/base/dists/binomial/variance
/stdlib update-copyright-years |
lib/node_modules/@stdlib/stats/base/dists/binomial/variance/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/binomial/variance/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/binomial/variance/benchmark/benchmark.native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/binomial/variance/src/Makefile
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/binomial/variance/lib/native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/binomial/variance/examples/c/Makefile
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/binomial/variance/lib/native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/binomial/variance/src/main.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/binomial/variance/manifest.json
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/binomial/variance/benchmark/c/benchmark.c
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR has a bunch of problems that will have to be addressed before it can be merged.
stats/base/dists/binomial/variance
stats/base/dists/binomial/variance
@Planeshifter Make all the changes. Please review all the changes. |
@Planeshifter Please review this, i have implemented ID_D as mention earlier. |
lib/node_modules/@stdlib/stats/base/dists/binomial/variance/src/main.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/binomial/variance/manifest.json
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/binomial/variance/src/main.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/binomial/variance/README.md
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/binomial/variance/src/main.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/binomial/variance/README.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Athan <[email protected]> Signed-off-by: Philipp Burckhardt <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's land it, thanks!
PR Commit Message
Please review the above commit message and make any necessary adjustments. |
Resolves #3477
Description
This pull request:
Related Issues
This pull request:
@stdlib/stats/base/dists/binomial/variance
#3477Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers