Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add C implementation for stats/base/dists/binomial/variance #3929

Merged
merged 9 commits into from
Jan 8, 2025

Conversation

0PrashantYadav0
Copy link
Contributor

@0PrashantYadav0 0PrashantYadav0 commented Dec 15, 2024

Resolves #3477

Description

What is the purpose of this pull request?

This pull request:

  • Adds C implementation for binomial Variance
  • Includes benchmarks for the C implementation.
  • Provides examples demonstrating the usage of the binomial Variance in C.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 15, 2024
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 15, 2024

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/binomial/variance $\color{red}173/176$
$\color{green}+98.30\%$
$\color{green}11/11$
$\color{green}+100.00\%$
$\color{red}1/2$
$\color{green}+50.00\%$
$\color{red}173/176$
$\color{green}+98.30\%$

The above coverage report was generated for the changes in this PR.

@0PrashantYadav0
Copy link
Contributor Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: In Progress Pull request is currently awaiting automation. labels Dec 15, 2024
@0PrashantYadav0 0PrashantYadav0 changed the title feat: Add C implementation for @stdlib/stats/base/dists/binomial/variance feat: Add C implementation for stats/base/dists/binomial/variance Dec 16, 2024
@0PrashantYadav0
Copy link
Contributor Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: In Progress Pull request is currently awaiting automation. labels Dec 16, 2024
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has a bunch of problems that will have to be addressed before it can be merged.

@0PrashantYadav0 0PrashantYadav0 changed the title feat: Add C implementation for stats/base/dists/binomial/variance feat: add C implementation for stats/base/dists/binomial/variance Dec 20, 2024
@0PrashantYadav0
Copy link
Contributor Author

@Planeshifter Make all the changes. Please review all the changes.

@0PrashantYadav0
Copy link
Contributor Author

@Planeshifter Please review this, i have implemented ID_D as mention earlier.

Co-authored-by: Athan <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's land it, thanks!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Jan 8, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jan 8, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add C implementation for `stats/base/dists/binomial/variance`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3929
Closes: https://github.com/stdlib-js/stdlib/issues/3477

Co-authored-by: Athan Reines <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@kgryte kgryte merged commit 3283517 into stdlib-js:develop Jan 8, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/binomial/variance
4 participants