feat: add math/base/special/ceil2f
#4164
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
The above coverage report was generated for the changes in this PR. |
Neerajpathak07
commented
Jan 8, 2025
| #include "stdlib/math/base/special/ceil2f.h" | ||
| #include "stdlib/math/base/napi/unary.h" | ||
|
|
||
| STDLIB_MATH_BASE_NAPI_MODULE_F_F( stdlib_base_ceil2f ) |
There was a problem hiding this comment.
@kgryte This files throws an error for Shadow declaration. The api call looks correct to me, anywhere else that it could be coming from?
There was a problem hiding this comment.
Yes, you need to disable the cppcheck rule here. See other packages, which do something similar.
Neerajpathak07
commented
Jan 8, 2025
|
|
||
| // Solve the equation `2^p = x` for `p`: | ||
| //need to add log2f | ||
| p = stdlib_base_log2( xc ); |
There was a problem hiding this comment.
will be adding log2f implementation after which will be updating this again!!
Neerajpathak07
commented
Jan 8, 2025
| if ( p > STDLIB_CONSTANT_FLOAT32_MAX_BASE2_EXPONENT ) { | ||
| return STDLIB_CONSTANT_FLOAT32_PINF; | ||
| } | ||
| return sign * stdlib_base_pow( 2.0, p ); |
There was a problem hiding this comment.
Do we need a powf implementation rather than pow for this.
There was a problem hiding this comment.
But actually, here, we can use exp2f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #649.
Description
This pull request:
math/base/special/ceil2fRelated Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers