Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeouts on listens should probably apply to "time since last receive" not entire operation. #241

Open
nbrooke opened this issue Oct 7, 2020 · 0 comments

Comments

@nbrooke
Copy link
Member

nbrooke commented Oct 7, 2020

When you set a timeout for a listen, the timeout applies to the time since the operation started, but in most cases it would make more sense for it to apply to the time since the last successful received data. Otherwise, there is no way to have a reasonable timeout on large data downloads, because you either need to set the time to something very large to make sure it has time to complete (in which case it will take a long time to error out) or if you set the timeout to short, you can get cancelled due to a time out while you are int e middle of actively receiving data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant