Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications for due decks #1526

Closed
tomtom opened this issue Sep 22, 2023 · 1 comment
Closed

Notifications for due decks #1526

tomtom opened this issue Sep 22, 2023 · 1 comment
Labels
enhancement New feature or request ✖️ wontfix This will not be worked on

Comments

@tomtom
Copy link

tomtom commented Sep 22, 2023

Is your feature request related to a problem? Please describe.
The app relies on the Nextcloud app for handling notifications/alarms of due cards. Unfortunately, the Nextcloud app is broken (in this respect) and, depending on the setup, does not handle notifications.

Describe the solution you'd like
It would be really great if the Deck app would handle alarms/notifications on its own on the phone/tablet. The Deck app should not rely on the user's nextcloud server or the Nextcloud app for this.

Additional context
I use the current version of the app from the Google app store.

@tomtom tomtom added the enhancement New feature or request label Sep 22, 2023
@stefan-niedermann
Copy link
Owner

Dear @tomtom

thank you for your suggestion.

The app relies on the Nextcloud app for handling notifications/alarms of due cards.

This is correct and described in our FAQ.

Unfortunately, the Nextcloud app is broken (in this respect)

Upstream issues are no excuse for permanent workarounds in downstream projects. If there's an Android bug, you wouldn't expect each app to handle the issue, would you? Solving the issue at the proper place will also make other users benefit form the solution and prevent multiple implementations in low-on-resources projects (like this one 😉)

depending on the setup, does not handle notifications

By "setup" you probably mean missing Google Play Services? I agree that this is a bad limitation (given I don't have installed Play Services myself). However the solution can only be to fix this in the Nextcloud Android app for example by a polling fallback (#7046) or implementing Unified Push (#8684).

We currently do not have any plans to duplicate and maintain the notification logic of the Deck server app, the Nextcloud Android app, merging possible offline notifications (due date) from the Deck Android app and online notifications (assignments, updates) from the Deck server app to the Nextcloud Android app including conflict resolution (which is not even possible because we can't know whether the Nextcloud Android app does or does not show Deck notifications).

Refs: #208 (comment)

@stefan-niedermann stefan-niedermann added the ✖️ wontfix This will not be worked on label Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ✖️ wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants