Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Remember sub-tab selection when navigating between top tabs #1032

Open
leighmcculloch opened this issue Sep 16, 2024 · 3 comments
Open
Assignees

Comments

@leighmcculloch
Copy link
Member

When navigating between top tabs the sub-tab selection appears to get lost.

Below is an example of navigating between the Sign sub-tab of Transactions, and the Accounts tab. When I navigate Sign -> Accounts -> Transactions, I'm taken to the Build Operations tab.

I can understand this has some advantages. When folks return to the Transactions tab after having finished what they're doing they are thrown at the start point of building, although oddly it's not actually the start point it's the Operations sub-page.

I know for myself when navigating an app I expect state to be retained, and most state does seem to be retained except the state of the sub-tab selection.

Screen.Recording.2024-09-16.at.10.55.49.AM.mov
@github-project-automation github-project-automation bot moved this to Backlog (Not Ready) in DevX Sep 16, 2024
@quietbits
Copy link
Contributor

@leighmcculloch, I want to make sure I understand your request. Is this the flow you'd like to see?

  1. Transaction > Build Transaction
  2. Transaction > Sign Transaction
  3. Account > Create Account Keypair (copy secret key)
  4. Transaction > Sign Transaction (instead of Build Transaction)

Would this apply to all pages or only Transactions?

@leighmcculloch
Copy link
Member Author

Would this apply to all pages or only Transactions?

I think if we make this change it should be consistent on all pages.

@janewang
Copy link
Contributor

janewang commented Nov 4, 2024

Image
Assigning to Charles for inset menu

@janewang janewang moved this from Backlog (Not Ready) to Backlog (Ready for Design) in DevX Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog (Ready for Design)
Development

No branches or pull requests

4 participants