Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ledger snapshots store both the key and values unnecessarily #1310

Open
leighmcculloch opened this issue Aug 1, 2024 · 0 comments
Open

Ledger snapshots store both the key and values unnecessarily #1310

leighmcculloch opened this issue Aug 1, 2024 · 0 comments
Assignees

Comments

@leighmcculloch
Copy link
Member

The ledger snapshot crate stores the key and value for each ledger entry, but that's unnecessary since the key data is store inside the entry, so more data is being stored than is necessary.

This would be a breaking change, but we could drop the key and rematerialize it, make the existing key field optional in the next major release.

@leighmcculloch leighmcculloch self-assigned this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@leighmcculloch and others