Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage example is missing from contract examples #1076

Closed
leighmcculloch opened this issue Nov 6, 2024 · 2 comments · Fixed by #1210
Closed

Storage example is missing from contract examples #1076

leighmcculloch opened this issue Nov 6, 2024 · 2 comments · Fixed by #1210
Assignees
@carstenjacobsen
Labels
bug Something isn't working dev-rel

Comments

@leighmcculloch
Copy link
Member

We used to have a storage example in the docs, but it's not showing up anymore. Most of the examples used progressively build on the storage example. From best I can tell we don't have a simple storage example anymore.

Looking at:
https://developers.stellar.org/docs/build/smart-contracts/example-contracts

Image
@leighmcculloch leighmcculloch added the bug Something isn't working label Nov 6, 2024
@github-project-automation github-project-automation bot moved this to Ideas in Dev Docs Nov 6, 2024
@leighmcculloch
Copy link
Member Author

The example still exists in the repo here:

@briwylde08 briwylde08 moved this from Ideas to To Do in Dev Docs Jan 7, 2025
carstenjacobsen added a commit to carstenjacobsen/stellar-docs that referenced this issue Jan 21, 2025
@carstenjacobsen
Adding Storage to example contracts stellar#1076
b306cbc 
The Increment smart contract is used. The documentation is based on the Getting Started - Storing Data guide.
@carstenjacobsen carstenjacobsen moved this from To Do to In Review in Dev Docs Jan 21, 2025
@briwylde08
Copy link
Contributor

#1210

@ElliotFriend ElliotFriend linked a pull request Jan 21, 2025 that will close this issue
Adding Storage to example contracts #1076 #1210
Merged
briwylde08 pushed a commit that referenced this issue Jan 22, 2025
@carstenjacobsen @ElliotFriend
Adding Storage to example contracts #1076 (#1210)
d9cf9fe 
* Adding Storage to example contracts #1076 

The Increment smart contract is used. The documentation is based on the Getting Started - Storing Data guide.

* markdown formatting

---------

Co-authored-by: Elliot Voris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carstenjacobsen carstenjacobsen

Labels
bug Something isn't working dev-rel
Projects
Dev Docs
Status: In Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding Storage to example contracts #1076 carstenjacobsen/stellar-docs
3 participants
@leighmcculloch @carstenjacobsen @briwylde08