Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 do not slice the data in include_hb1ac() #139

Open
signekb opened this issue Sep 19, 2024 · 0 comments
Open

fix: 🐛 do not slice the data in include_hb1ac() #139

signekb opened this issue Sep 19, 2024 · 0 comments

Comments

@signekb
Copy link
Contributor

signekb commented Sep 19, 2024

Regarding line 36-37: We should actually not slice the data to the first two observations yet. This has to wait until after the events have been through the censoring function(s). E.g. if we do it now, we risk that one or both of the first two elevated HbA1c tests were due to gestational diabetes and need to be excluded.
The same thing goes for GLD drugs (which need to go through three censoring functions, while HbA1c only needs to go through one: exclude_pregnancy()), but include_gld_purchases() doesn't slice the data, so that function is fine 👍

Originally posted by @Aastedet in #138 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant