Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying several ARTICLE_PRICE_DETAILS elements in order to be able to specify prices for different time periods #6

Open
ninjaGuerri opened this issue Oct 21, 2024 · 1 comment

Comments

@ninjaGuerri
Copy link

Hello,
I am using BMECat.net trying to export a catalog following the BMECat 1.2 standard.
As we can see in the official documentation at page 97, we could specify a start and an end date to specify the price validation period.
However, inspecting this library classes I see that the ProductPrice list is mapped directly inside the tag ARTICLE_PRICE_DETAILS without the possibility to specify any other property.
Am I misunderstanding something? Can I specify the price validation period in some other way?
Thank you

@stephanstapel
Copy link
Owner

Hi,
you are right, these attributes are not yet implemented in the library. If you like, add them, it should be quite straight-forward. I'm happy to review your pull request.
Cheers,
Stephan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants