You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 9, 2018. It is now read-only.
Since APNS socket connection is not synchronous should we not be restarting at the device that failed based on the return message from APNS and not at the current device we are iterating over?
I might be misunderstanding how error handling happens when we call send on the APNS connection. It seems to me that since the error will lag behind our processing server side we will be catch the error on the wrong device leading to skipping a number of devices between the one that closed the connection and the one we are currently processing.
The text was updated successfully, but these errors were encountered:
Agreed. That's more a reference as to how this library should handle errors. Currently, I think the issue that you raised is valid and should be addressed.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
APNService class | _write_message
Since APNS socket connection is not synchronous should we not be restarting at the device that failed based on the return message from APNS and not at the current device we are iterating over?
I might be misunderstanding how error handling happens when we call send on the APNS connection. It seems to me that since the error will lag behind our processing server side we will be catch the error on the wrong device leading to skipping a number of devices between the one that closed the connection and the one we are currently processing.
The text was updated successfully, but these errors were encountered: