Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a transition between lqip and final image #112

Open
adrienharnay opened this issue Oct 16, 2018 · 6 comments
Open

Add a transition between lqip and final image #112

adrienharnay opened this issue Oct 16, 2018 · 6 comments

Comments

@adrienharnay
Copy link

  • react-ideal-image version: 2.2.0
  • node version: 10.11.0
  • npm (or yarn) version: Yarn 1.9.4

Relevant code or config

I will take the demo as an example: https://stereobooster.github.io/react-ideal-image-experiments/

What you did: Load the page

What happened: No transition between blurred image and final image

Reproduction repository: Again, using the demo

Problem description: It is a bit rough going from lqip to final image without any kind of transition

Suggested solution: Would be neat to implement it. Would be up for it if given pointers 👍

Thanks for this awesome package!

@stereobooster
Copy link
Owner

Hey. By transition you mean some kind of animation, like fade-in or something? I guess this can be done with css animation

@adrienharnay
Copy link
Author

Hey, yes this is totally what I meant! I tried animation, but since the background-image placeholder is removed as soon as the final image appears, there is a white flash before the image fades in. I think this could be managed in react-ideal-image, what do you think?

@stereobooster
Copy link
Owner

In general yes, but I do not have time for it right now. Also build is broken in the master, I guess this is because I merged renovate branch with update of the babel

@adrienharnay
Copy link
Author

I understand. I would be eager to hep you fix the build and develop this feature when you will have some time 🙂

@yosbelms
Copy link

@adrienharnay, @stereobooster The Img component of this lib has smooth transitions, maybe it can useful as example of what you want to do.

@adrienharnay
Copy link
Author

Hey, thanks for the pointer but I instead went with gatsby-image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants