Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the adjoint_tests LFRic App to the integration testing #2771

Open
arporter opened this issue Nov 8, 2024 · 3 comments
Open

Add the adjoint_tests LFRic App to the integration testing #2771

arporter opened this issue Nov 8, 2024 · 3 comments
Labels
adjoint enhancement LFRic Issue relates to the LFRic domain

Comments

@arporter
Copy link
Member

arporter commented Nov 8, 2024

Recently we introduced a bug to PSyAD that wasn't caught until the MO tested with the latest PSyclone. Now that LFRic Apps has the adjoint_tests App, we could extend the integration tests to build and run it. Can you foresee any problems with that @DrTVockerodtMO (i.e. additional dependencies etc.)?

@arporter arporter added enhancement LFRic Issue relates to the LFRic domain adjoint labels Nov 8, 2024
@arporter
Copy link
Member Author

arporter commented Nov 8, 2024

I think we want to wait to do this until we move all of the LFRic integration testing up to the new (1.2?) release of LFRic Apps. @TeranIvy might have a view too.

@DrTVockerodtMO
Copy link
Collaborator

DrTVockerodtMO commented Nov 8, 2024

I think with the new release cycle as opposed to just versioning it seems doable. Note that previously discussions were held where the adjoint is permitted to be broken (i.e.: fail the LFRic tests) for a time whilst we endeavour to fix it. So there could be a situation where the LFRic integration tests in PSyclone expectedly fail through no fault of PSyclone itself.

In my (limited) experience I have been fast enough on tickets such that I can fix the adjoint_tests app during that ticket's life cycle but there is provision at least for it to be broken for more time, hopefully not between two different versions I would think but I am not sure. Could be tricky!

@arporter
Copy link
Member Author

arporter commented Nov 8, 2024

Thanks @DrTVockerodtMO. We don't update our LFRic environment very often so I think we could just choose a version where PSyAD is known to work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adjoint enhancement LFRic Issue relates to the LFRic domain
Projects
None yet
Development

No branches or pull requests

2 participants