Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test tutorials #16

Open
ElliottKasoar opened this issue Nov 29, 2024 · 4 comments
Open

Test tutorials #16

ElliottKasoar opened this issue Nov 29, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@ElliottKasoar
Copy link
Member

We may want to build an image per commit to janus-core main, but it may be easiest/less wasteful to test against every release.

@ElliottKasoar ElliottKasoar added the enhancement New feature or request label Nov 29, 2024
@ElliottKasoar ElliottKasoar self-assigned this Nov 29, 2024
@ElliottKasoar
Copy link
Member Author

@harveydevereux can you open a PR with the Dockerfile for janus, then we can both work on the branch?

Other than the Dockerfile, we still need a nice way of running the notebooks, and ideally a trigger based on new tags in janus-core, but perhaps we can manually trigger it as a first step.

@alinelena
Copy link
Member

I will not oppose moving the tutorials in janus-core itself if that makes the running easier

@harveydevereux
Copy link

Hopefully can get a buildable docker file today

I will not oppose moving the tutorials in janus-core itself if that makes the running easier

I think we could either use some webhook method, or apparently it is possible to do a "cron action" that could check the release tag [1]. Otherwise manual, or integrate I suppose.

on:
  schedule:
    - cron:  '0 10 * * *'

[1] https://stackoverflow.com/questions/58465057/trigger-a-github-action-when-another-repository-creates-a-new-release

@harveydevereux harveydevereux mentioned this issue Dec 16, 2024
4 tasks
@alinelena
Copy link
Member

i will do it on tag there is something like this

on:
  push:
    tags:        
      - '*' 

so we create docker images only when we release.
I will stick to one python version, 3.11 eg now. and have it done in a conda/mamba environment.

even happy to start from something like this https://github.com/jupyterhub/jupyter-remote-desktop-proxy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants