-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test tutorials #16
Comments
@harveydevereux can you open a PR with the Dockerfile for janus, then we can both work on the branch? Other than the Dockerfile, we still need a nice way of running the notebooks, and ideally a trigger based on new tags in janus-core, but perhaps we can manually trigger it as a first step. |
I will not oppose moving the tutorials in janus-core itself if that makes the running easier |
Hopefully can get a buildable docker file today
I think we could either use some webhook method, or apparently it is possible to do a "cron action" that could check the release tag [1]. Otherwise manual, or integrate I suppose.
|
i will do it on tag there is something like this on:
push:
tags:
- '*' so we create docker images only when we release. even happy to start from something like this https://github.com/jupyterhub/jupyter-remote-desktop-proxy |
We may want to build an image per commit to janus-core main, but it may be easiest/less wasteful to test against every release.
The text was updated successfully, but these errors were encountered: