From b46c35a89bd60873bf64350d7fbbdf8a47c482d8 Mon Sep 17 00:00:00 2001
From: Ravenwater <theo@stillwater-sc.com>
Date: Fri, 23 Feb 2024 13:58:56 -0500
Subject: [PATCH] clean up of 2-parameter skeleton

---
 .../number/skeleton_2params/attributes.hpp    |  6 +-
 include/universal/number/skeleton_2params/bla | 74 -------------------
 2 files changed, 3 insertions(+), 77 deletions(-)
 delete mode 100644 include/universal/number/skeleton_2params/bla

diff --git a/include/universal/number/skeleton_2params/attributes.hpp b/include/universal/number/skeleton_2params/attributes.hpp
index d60013323..2563fbb48 100644
--- a/include/universal/number/skeleton_2params/attributes.hpp
+++ b/include/universal/number/skeleton_2params/attributes.hpp
@@ -17,15 +17,15 @@ namespace sw { namespace universal {
 
 	// free function sign
 template<unsigned nbits, unsigned es, typename bt>
-bool sign(const twoparam<nbits, bt>& v) {
+bool sign(const twoparam<nbits, es, bt>& v) {
 	return v.sign();
 }
 
 // generate the maxneg through maxpos value range of a logarithmic number system configuration
 // the type of arithmetic, Modulo or Saturating, does not affect the range
 template<unsigned nbits, unsigned es, typename bt>
-std::string twoparam_range(const twoparam<nbits, bt) {
-	using TWOPARAM = twoparam<nbits, bt>;
+std::string twoparam_range(const twoparam<nbits, es, bt>& a) {
+	using TWOPARAM = twoparam<nbits, es, bt>;
 	std::stringstream s;
 	TWOPARAM l;
 	s << std::setw(45) << type_tag(v) << " : [ "
diff --git a/include/universal/number/skeleton_2params/bla b/include/universal/number/skeleton_2params/bla
deleted file mode 100644
index e38f1f249..000000000
--- a/include/universal/number/skeleton_2params/bla
+++ /dev/null
@@ -1,74 +0,0 @@
-#pragma once
-// exceptions.hpp: exception hierarchy for exceptions during posit calculations
-//
-// Copyright (C) 2017 Stillwater Supercomputing, Inc.
-//
-// This file is part of the universal numbers project, which is released under an MIT Open Source license.
-#include <universal/common/exceptions.hpp>
-
-namespace sw { namespace universal {
-
-///////////////////////////////////////////////////////////////////////////////////////////////////
-/// POSIT ARITHMETIC EXCEPTIONS
-
-// base class for posit arithmetic exceptions
-struct posit_arithmetic_exception : public universal_arithmetic_exception {			
-	posit_arithmetic_exception(const std::string& error) 
-		: universal_arithmetic_exception(std::string("posit arithmetic exception: ") + error) {};
-};
-
-//////////////////////////////////////////////////////////////////////////////////////////////////
-/// specialized exceptions to aid application level exception handling
-
-// not_a_real is thrown when a rvar is NaR
-struct posit_nar : public posit_arithmetic_exception {
-	posit_nar() : posit_arithmetic_exception("nar (not a real)") {}
-};
-
-// divide_by_zero is thrown when the denominator in a division operator is 0
-struct posit_divide_by_zero : public posit_arithmetic_exception {
-	posit_divide_by_zero() : posit_arithmetic_exception("divide by zero") {}
-};
-
-// divide_by_nar is thrown when the denominator in a division operator is NaR
-struct posit_divide_by_nar : public posit_arithmetic_exception {
-	posit_divide_by_nar() : posit_arithmetic_exception("divide by nar") {}
-};
-
-// numerator_is_nar is thrown when the numerator in a division operator is NaR
-struct posit_numerator_is_nar : public posit_arithmetic_exception {
-	posit_numerator_is_nar() : posit_arithmetic_exception("numerator is nar") {}
-};
-
-// operand_is_nar is thrown when an rvar in a binary operator is NaR
-struct posit_operand_is_nar : public posit_arithmetic_exception {
-	posit_operand_is_nar() : posit_arithmetic_exception("operand is nar") {}
-};
-
-// thrown when division yields no signficant fraction bits
-struct posit_division_result_is_zero : public posit_arithmetic_exception {
-	posit_division_result_is_zero() : posit_arithmetic_exception("division yielded no significant bits") {}
-};
-
-// thrown when division yields NaR
-struct posit_division_result_is_infinite : public posit_arithmetic_exception {
-	posit_division_result_is_infinite() : posit_arithmetic_exception("division yielded infinite") {}
-};
-
-///////////////////////////////////////////////////////////////////////////////////////////////////
-/// POSIT INTERNAL OPERATION EXCEPTIONS
-
-struct posit_internal_exception	: public universal_internal_exception {
-	posit_internal_exception(const std::string& error) 
-		: universal_internal_exception(std::string("posit internal exception: ") + error) {};
-};
-
-struct posit_hpos_too_large : public posit_internal_exception {
-	posit_hpos_too_large() : posit_internal_exception("position of hidden bit too large for given posit") {}
-};
-
-struct posit_rbits_too_large : public posit_internal_exception {
-	posit_rbits_too_large() :posit_internal_exception("number of remaining bits too large for this fraction") {}
-};
-
-}} // namespace sw::universal